Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog pinch zoom #7012

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Dialog pinch zoom #7012

wants to merge 4 commits into from

Conversation

tomdohnal
Copy link

Closes #1898

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@devongovett devongovett force-pushed the main branch 2 times, most recently from a79adcf to 3013156 Compare September 30, 2024 21:00
@snowystinger
Copy link
Member

I followed the instructions to in the issue to verify the fix. It only appears to work once, the second field i enter zooms again and i'm unable to pinch back out.

Maybe for the moment we just do this suggestion #1898 (comment) so it doesn't zoom in to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useDialog: Pinch-to-zoom on iOS
3 participants
@tomdohnal @snowystinger @reidbarber